-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Payment Metadata #8335
Merged
Merged
Add Payment Metadata #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwill
reviewed
May 5, 2021
generate code: |
may need to run |
xli
reviewed
May 6, 2021
sunmilee
force-pushed
the
paymentmetadata
branch
3 times, most recently
from
May 6, 2021 21:34
575a0c0
to
b189088
Compare
xli
approved these changes
May 7, 2021
/land |
Cluster Test Result
Repro cmd:
🎉 Land-blocking cluster test passed! 👌 |
bors-libra
force-pushed
the
paymentmetadata
branch
from
May 7, 2021 20:09
b189088
to
5359f06
Compare
zgfzgf
pushed a commit
to zgfzgf/diem
that referenced
this pull request
Jun 8, 2021
Closes: diem#8335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding new metadata type PaymentMetadata as defined in DIP-10. Used for transactions that are specific to payments that can we looked up using a reference ID.
Test Plan
unit test suite