Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Metadata #8335

Merged
merged 2 commits into from
May 7, 2021
Merged

Add Payment Metadata #8335

merged 2 commits into from
May 7, 2021

Conversation

sunmilee
Copy link

@sunmilee sunmilee commented May 5, 2021

Motivation

Adding new metadata type PaymentMetadata as defined in DIP-10. Used for transactions that are specific to payments that can we looked up using a reference ID.

Test Plan

unit test suite

@bors-libra bors-libra added this to In Review in bors May 5, 2021
@sunmilee sunmilee requested a review from xli May 5, 2021 20:34
@xli
Copy link
Contributor

xli commented May 6, 2021

generate code: cargo run -p generate-format -- --corpus diem --record

@xli
Copy link
Contributor

xli commented May 6, 2021

may need to run cargo run --release -p stdlib

@sunmilee sunmilee force-pushed the paymentmetadata branch 3 times, most recently from 575a0c0 to b189088 Compare May 6, 2021 21:34
@sunmilee sunmilee requested review from xli, bmwill and davidiw May 6, 2021 22:32
@sunmilee
Copy link
Author

sunmilee commented May 7, 2021

/land

@bors-libra bors-libra moved this from In Review to Queued in bors May 7, 2021
@bors-libra bors-libra moved this from Queued to Testing in bors May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

Cluster Test Result

Test runner setup time spent 279 secs
Compatibility test results for land_211f4bd8 ==> land_5359f060 (PR)
1. All instances running land_211f4bd8, generating some traffic on network
2. First full node land_211f4bd8 ==> land_5359f060, to validate new full node to old validator node traffic
3. First Validator node land_211f4bd8 ==> land_5359f060, to validate storage compatibility
4. First batch validators (14) land_211f4bd8 ==> land_5359f060, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_211f4bd8 ==> land_5359f060
6. Second batch validators (15) land_211f4bd8 ==> land_5359f060, to upgrade rest of the validators
7. Second batch of full nodes (15) land_211f4bd8 ==> land_5359f060, to finish the network upgrade, time spent 876 secs
all up : 872 TPS, 5209 ms latency, 6150 ms p99 latency, no expired txns, time spent 250 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-05-07T19:44:06Z',to:'2021-05-07T20:09:18Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1620416646000&to=1620418158000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-05-07T19:44:06Z',to:'2021-05-07T20:09:18Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_211f4bd8 --cluster-test-tag land_5359f060 -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_5359f060 --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@bors-libra bors-libra removed this from Testing in bors May 7, 2021
@bors-libra bors-libra closed this in 5359f06 May 7, 2021
@bors-libra bors-libra merged commit 5359f06 into diem:main May 7, 2021
@bors-libra bors-libra temporarily deployed to Sccache May 7, 2021 20:09 Inactive
@bors-libra bors-libra temporarily deployed to Docker May 7, 2021 20:09 Inactive
@sunmilee sunmilee mentioned this pull request May 11, 2021
24 tasks
zgfzgf pushed a commit to zgfzgf/diem that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants