[scratchpad] sophisticated Criterion benchmarks #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmouse
requested review from
wqfish,
lightmark,
gelash,
runtian-zhou and
zekun000
msmouse
force-pushed
the
naive_bench
branch
3 times, most recently
from
47d2ef7
to
de22bcc
Compare
zekun000
approved these changes
May 13, 2021
| } | ||
|
|
||
| criterion_group!(benches, insert_to_empty); | ||
| // criterion_group!(benches, insert_to_empty, update_exiting_keys_out_of_1mil); |
| group.finish(); | ||
|
|
||
| fn gen_value(rng: &mut StdRng) -> AccountStateBlob { | ||
| rng.gen::<[u8; 32]>().to_vec().into() |
There was a problem hiding this comment.
It's planned that the global SMT leaves carry account "authenticator"s which are hash values.
There was a problem hiding this comment.
Actually.. that plus the chaining structure. I'l do 100bytes then.
msmouse
force-pushed
the
naive_bench
branch
2 times, most recently
from
2e60178
to
069ca8f
Compare
|
/land |
Check generate root hash and proofs with this so that we don't need to rely on the DB (the JellyFish indeed) in tests and benchmarks. The update interface of the JellyFish might change and depend on the scratchpad instead.
Based on the NaiveSmt newly introduced, benchmark the updating time in these three cases: 1. inserting to an empty SMT; 2. inserting to an SMT with a committed base (root is "unknown" hence all information about the base tree must be known through the proof reader; 3. updating an SMT with some in mem nodes. Closes: diem#8388
|
Cluster Test Result Repro cmd: 🎉 Land-blocking cluster test passed! 👌 |
zgfzgf
pushed a commit
to zgfzgf/diem
that referenced
this pull request
Jun 8, 2021
Based on the NaiveSmt newly introduced, benchmark the updating time in these three cases: 1. inserting to an empty SMT; 2. inserting to an SMT with a committed base (root is "unknown" hence all information about the base tree must be known through the proof reader; 3. updating an SMT with some in mem nodes. Closes: diem#8388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
(This is on top of #8386, including its two commits before it got landed.)
Based on the NaiveSmt newly introduced, benchmark the updating time in these three cases: 1. inserting to an empty SMT; 2. inserting to an SMT with a committed base (root is "unknown" hence all information about the base tree must be known through the proof reader; 3. updating an SMT with some in mem nodes.
The
NaiveSmtis under the feature "bench", and when running the bench "--features bench" needs to be in the command line, which is not ideal. ProbablyNaiveSmtneeds to be split into its own crate.Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
benchmark updated
cargo bench -p scratchpad --features bench
Related PRs
#8386