New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move] Rename compiler
crate move-ir-compiler
#9782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modocache
force-pushed
the
move-ir-compiler-rename
branch
from
November 16, 2021 21:23
36379e8
to
a7e5f31
Compare
vgao1996
previously approved these changes
Nov 16, 2021
modocache
force-pushed
the
move-ir-compiler-rename
branch
from
November 17, 2021 17:34
a7e5f31
to
6d9f3fb
Compare
LEC dependency change summary:
|
release binaries dependency change summary:
|
vgao1996
previously approved these changes
Nov 17, 2021
/land |
/land |
@modocache 💡 This PR is already queued for landing |
There was once a time where the only compiled language in the project was Move IR, and there was only a single compiler for it, so the name "compiler" was unambiguous. However, now that the Move source language exists, it's clearer to rename the `compiler` crate to `move-ir-compiler`. I feel now is a good time to do this, because I'd like to add a transactional test runner crate for the Move IR compiler, and that involves giving it a name. I could name it `compiler-transactional-tests`, but that would create yet another ambiguously named crate in the repository. I figure it's better to rename the `compiler` crate first, then add the test runner. Closes: diem#9782
Forge Test Result
Repro cmd:
🎉 Land-blocking forge test passed! 👌 |
Cluster Test Result
Repro cmd:
🎉 Land-blocking cluster test passed! 👌 |
bors-libra
force-pushed
the
move-ir-compiler-rename
branch
from
November 18, 2021 01:51
6d9f3fb
to
6448acf
Compare
Oh, thank you so much for doing this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was once a time where the only compiled language in the project was Move IR, and there was only a single compiler for it, so the name "compiler" was unambiguous. However, now that the Move source language exists, it's clearer to rename the
compiler
crate tomove-ir-compiler
.I feel now is a good time to do this, because I'd like to add a transactional test runner crate for the Move IR compiler, and that involves giving it a name. I could name it
compiler-transactional-tests
, but that would create yet another ambiguously named crate in the repository. I figure it's better to rename thecompiler
crate first, then add the test runner.