Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Rename compiler crate move-ir-compiler #9782

Merged
merged 1 commit into from Nov 18, 2021

Conversation

modocache
Copy link
Contributor

There was once a time where the only compiled language in the project was Move IR, and there was only a single compiler for it, so the name "compiler" was unambiguous. However, now that the Move source language exists, it's clearer to rename the compiler crate to move-ir-compiler.

I feel now is a good time to do this, because I'd like to add a transactional test runner crate for the Move IR compiler, and that involves giving it a name. I could name it compiler-transactional-tests, but that would create yet another ambiguously named crate in the repository. I figure it's better to rename the compiler crate first, then add the test runner.

@bors-libra bors-libra added this to In Review in bors Nov 16, 2021
@modocache modocache marked this pull request as ready for review November 16, 2021 22:09
@modocache modocache requested a review from a team as a code owner November 16, 2021 22:09
vgao1996
vgao1996 previously approved these changes Nov 16, 2021
@libra-action
Copy link

LEC dependency change summary:

target packages:
  M bytecode-source-map 0.1.0 (workspace, path 'language/move-ir-compiler/bytecode-source-map')
    * source changed from path 'language/compiler/bytecode-source-map'
    * (unchanged features: default)
  M ir-to-bytecode 0.1.0 (workspace, path 'language/move-ir-compiler/ir-to-bytecode')
    * source changed from path 'language/compiler/ir-to-bytecode'
    * (unchanged features: default)
  M ir-to-bytecode-syntax 0.1.0 (workspace, path 'language/move-ir-compiler/ir-to-bytecode/syntax')
    * source changed from path 'language/compiler/ir-to-bytecode/syntax'
    * (unchanged features: default)

@libra-action
Copy link

release binaries dependency change summary:

target packages:
  M bytecode-source-map 0.1.0 (workspace, path 'language/move-ir-compiler/bytecode-source-map')
    * source changed from path 'language/compiler/bytecode-source-map'
    * (unchanged features: default)
  M ir-to-bytecode 0.1.0 (workspace, path 'language/move-ir-compiler/ir-to-bytecode')
    * source changed from path 'language/compiler/ir-to-bytecode'
    * (unchanged features: default)
  M ir-to-bytecode-syntax 0.1.0 (workspace, path 'language/move-ir-compiler/ir-to-bytecode/syntax')
    * source changed from path 'language/compiler/ir-to-bytecode/syntax'
    * (unchanged features: default)

vgao1996
vgao1996 previously approved these changes Nov 17, 2021
@modocache
Copy link
Contributor Author

/land

@bors-libra bors-libra moved this from In Review to Queued in bors Nov 17, 2021
@modocache
Copy link
Contributor Author

/land

@bors-libra
Copy link
Contributor

@modocache 💡 This PR is already queued for landing

There was once a time where the only compiled language in the project
was Move IR, and there was only a single compiler for it, so the name
"compiler" was unambiguous. However, now that the Move source language
exists, it's clearer to rename the `compiler` crate to
`move-ir-compiler`.

I feel now is a good time to do this, because I'd like to add a
transactional test runner crate for the Move IR compiler, and that
involves giving it a name. I could name it
`compiler-transactional-tests`, but that would create yet another
ambiguously named crate in the repository. I figure it's better to
rename the `compiler` crate first, then add the test runner.

Closes: diem#9782
@bors-libra bors-libra moved this from Queued to Testing in bors Nov 18, 2021
@github-actions
Copy link

Forge Test Result

Compatibility test results for land_566a6555 ==> land_6448acff (PR)
1. Downgrade all validators to older version: land_566a6555
2. Upgrading first Validator to new version: land_6448acff
3. Upgrading rest of first batch to new version: land_6448acff
4. upgrading second batch to new version: land_6448acff
5. check swarm health
Compatibility test for land_566a6555 ==> land_6448acff passed
performance::performance-benchmark : 1660 TPS, 2693 ms latency, 8100 ms p99 latency,no expired txns
Logs: https://diem-development.kb.us-west1.gcp.cloud.es.io:9243/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(),filters:!(),index:'2da2a6e0-f70a-11eb-ad53-b979a6c9b83a',interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))
Dashboard: http://mon.forge-1.aws.hlw3truzy4ls.com/d/overview/overview?from=1637197965186&to=1637199303626&orgId=1

Repro cmd:

./scripts/fgi/run --tag land_6448acff --base-image-tag land_566a6555 --suite land_blocking_compat --report forge_report.json

🎉 Land-blocking forge test passed! 👌

@github-actions
Copy link

Cluster Test Result

Test runner setup time spent 685 secs
Compatibility test results for land_566a6555 ==> land_6448acff (PR)
1. All instances running land_566a6555, generating some traffic on network
2. First full node land_566a6555 ==> land_6448acff, to validate new full node to old validator node traffic
3. First Validator node land_566a6555 ==> land_6448acff, to validate storage compatibility
4. First batch validators (14) land_566a6555 ==> land_6448acff, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_566a6555 ==> land_6448acff
6. Second batch validators (15) land_566a6555 ==> land_6448acff, to upgrade rest of the validators
7. Second batch of full nodes (15) land_566a6555 ==> land_6448acff, to finish the network upgrade, time spent 613 secs
all up : 2110 TPS, 2131 ms latency, 4500 ms p99 latency, no expired txns, time spent 264 secs
Logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-11-18T01:12:24Z',to:'2021-11-18T01:41:47Z'))
Dashboard: http://grafana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1637197944000&to=1637199707000
Validator 1 logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-11-18T01:12:24Z',to:'2021-11-18T01:41:47Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_566a6555 --cluster-test-tag land_6448acff -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_6448acff --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@bors-libra bors-libra removed this from Testing in bors Nov 18, 2021
@bors-libra bors-libra merged commit 6448acf into diem:main Nov 18, 2021
@bors-libra bors-libra temporarily deployed to Sccache November 18, 2021 01:51 Inactive
@bors-libra bors-libra temporarily deployed to Docker November 18, 2021 01:52 Inactive
@bors-libra bors-libra temporarily deployed to Sccache November 18, 2021 01:52 Inactive
@modocache modocache deleted the move-ir-compiler-rename branch November 18, 2021 02:20
@bob-wilson
Copy link
Contributor

Oh, thank you so much for doing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants