Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evm] add support for Tables #139

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[evm] add support for Tables #139

merged 1 commit into from
Mar 23, 2022

Conversation

emmazzz
Copy link
Contributor

@emmazzz emmazzz commented Mar 22, 2022

Motivation

This PR implements support for tables in move-to-yul compiler.
Also fixes two small bugs:

  • When hashing (word, group) in StorageKey function, group should be shifted left to be at the beginning of the second word.
  • FreezeRef should be treated like an assignment.

Copy link
Contributor

@wrwg wrwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller things.

language/evm/move-to-yul/src/context.rs Show resolved Hide resolved
language/evm/move-to-yul/src/tables.rs Outdated Show resolved Hide resolved
wrwg
wrwg previously approved these changes Mar 23, 2022
@emmazzz
Copy link
Contributor Author

emmazzz commented Mar 23, 2022

/land

@bors-diem bors-diem moved this from In Review to Queued in bors Mar 23, 2022
@bors-diem bors-diem moved this from Queued to Testing in bors Mar 23, 2022
@bors-diem bors-diem removed this from Testing in bors Mar 23, 2022
@bors-diem bors-diem merged commit 3461627 into diem:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants