Issue 148: "Stuck client" may not be detected in case of non-open socket #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 1, 2020 09:13
eolivelli
commented
Jul 1, 2020
| @@ -601,7 +601,7 @@ public void replyReceived(Message originalMessage, Message message, Throwable er | |||
|
|
|||
| void processIdleConnection() { | |||
| Channel _channel = channel; | |||
| if (_channel != null && _channel.isValid()) { | |||
| if (_channel != null) { | |||
There was a problem hiding this comment.
This is actually the fix !
diegosalvi
approved these changes
Jul 1, 2020
| @@ -601,7 +601,7 @@ public void replyReceived(Message originalMessage, Message message, Throwable er | |||
|
|
|||
| void processIdleConnection() { | |||
| Channel _channel = channel; | |||
| if (_channel != null && _channel.isValid()) { | |||
| if (_channel != null) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of unhandled exception on the server side we are marking the connection as "not valid" and thus we are not processing pending messages anymore.
With this change the processing of pending messages is executed even in case of "failed" NettyChannel.
The new test case hangs without this change
Fixes #164