update chart #128
update chart #128
Conversation
|
Thanks for the commit. LGTM but I'm not experienced with helm configs. I'll merge by tomorrow if others have no comments |
kubernetes/bkvm/values.yaml
Outdated
| imagePullPolicy: Always | ||
|
|
||
| jdbcUrl: jdbc:herddb:local:temporary | ||
| metadataServiceUri: zk://pulsar-zookeeper:2181/ledgers |
There was a problem hiding this comment.
Could you remove the pulsar reference?
There was a problem hiding this comment.
Do you want it empty or this string "zk://zookeeper:2181/ledgers" instead ?
There was a problem hiding this comment.
I think that most of the users currently are using Pulsar
I would keep pulsar-zookeeper in order to make it easier
Not a big deal as far as we keep this configurable
maybe you can keep a comment to explain how to use it with the Apache Pulsar helm chart
| labels: | ||
| {{ toYaml .Values.server.labels | nindent 4 }} | ||
| spec: | ||
| replicas: 1 |
There was a problem hiding this comment.
this should be configurable
There was a problem hiding this comment.
I don't think that BKVM supports multiple instances at the moment (because there is no handling of distributed sessions).
I think that we should keep 1 here
There was a problem hiding this comment.
I didn't test it with several replicas but one replica works with Pulsar
|
good work @enzo-dechaene ! |
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.