fix: deleted ledgers are not removed from the cache #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Apr 30, 2024
| @@ -283,12 +283,11 @@ public void doRefreshMetadataCache() { | |||
| } | |||
|
|
|||
| Iterable<Long> ledgersIds = bkAdmin.listLedgers(); | |||
| metadataCache.clearLedgers(clusterId); | |||
There was a problem hiding this comment.
I see 2 problems here:
- if something goes wrong in the loop the database will be empty
- if you have many ledgers for some time the users will see less data than expected (wrong results in the queries)
why do we have do it this way ?
nicoloboschi
force-pushed
the
fix-ledgers-deletion
branch
from
ee520ce
to
11b7424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production clusters using Pulsar we noticed deleted ledgers are not removed from the cache.
Fixes: