Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWe don't handle or verify the order of the columns #2
Comments
This comment has been minimized.
|
This can also potentially lead to memory unsafety if the table is declared with the right columns, but in a different order than they exist in the schema, causing the wrong types to be applied and potentially breaking some invariant of the output. |
This comment has been minimized.
|
Fixed by 4ebd0c1 |
sgrif
closed this
Nov 21, 2015
added a commit
that referenced
this issue
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedOct 1, 2015
We need to test for this. For example, if we have
There's nothing to prevent
which would read the fields into the wrong pieces of the struct. The obvious solution is to access by the name of the fields, but then we have to figure out more concrete aliasing behavior and couple to it which I don't want. Needs further investigation.