Ensure batch inserts on SQLite run in a transaction #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
force-pushed
the
sg-ensure-sqlite-in-transaction
branch
3 times, most recently
from
88b7412
to
b0cf840
Compare
While it's safe for us to do the inserts one query at a time, due to the lack of round-trip time on SQLite, there's still a significant performance difference if done outside of a transaction. If we're not in a transaction, SQLite will perform table locking, and file IO for each query individually. This also means that batch insert on SQLite will have the same semantics on failure as the other backends. While I previously thought that we did not want a savepoint here if we were already in a transaction, it's actually important that we create one in order to match the semantics of other backends on failure. Fixes #1177.
sgrif
force-pushed
the
sg-ensure-sqlite-in-transaction
branch
from
b0cf840
to
59f59e3
Compare
Eijebong
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's safe for us to do the inserts one query at a time, due to the
lack of round-trip time on SQLite, there's still a significant
performance difference if done outside of a transaction. If we're not in
a transaction, SQLite will perform table locking, and file IO for each
query individually.
This also means that batch insert on SQLite will have the same semantics
on failure as the other backends.
While I previously thought that we did not want a savepoint here if we
were already in a transaction, it's actually important that we create
one in order to match the semantics of other backends on failure.
Fixes #1177.