Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite AsChangeset using syn 0.12 #1512

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Rewrite AsChangeset using syn 0.12 #1512

merged 2 commits into from
Jan 31, 2018

Commits on Jan 24, 2018

  1. Rewrite AsChangeset using syn 0.12

    In order to update to syn 0.12, we're going to have to rewrite a lot of
    `diesel_derives`. A lot of code is incompatible with no obvious
    migration path. I also want to take this as an opportunity to do a lot
    of long needed refactoring to this library.
    
    Despite continuous assertions that outputting `compile_error!` somehow
    makes our error messages significantly better (it really doesn't, it
    just avoids "proc-macro panicked") -- I am panicking in error cases
    here. One of the benefits of syn 0.12 is that it retains span
    information, which we can use on nightly to output errors with real
    diagnostics. I haven't made that jump here quite yet, but I plan to in a
    followup PR.
    
    Since this is the first derive moved over to the new crate, it includes
    much more code than PRs for the rest will.
    sgrif committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    72614e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. syn::Ident is now Copy

    Also fixes a potential future issue with generic structs. Without the
    `.split_for_impl` line, we would fail on any type parameter with
    defaults (right now we don't support generic structs at all here, but
    this will be needed if we ever do)
    sgrif committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    c16ec6a View commit details
    Browse the repository at this point in the history