Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipnet-address feature, providing conversions to/from the ipnet crate #3165

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

smklein
Copy link
Contributor

@smklein smklein commented May 3, 2022

NOTE: this is one possible prototype of #3164

Details:

  • This adds an ipnet-address feature, which acts exactly like network-address, but using the ipnet crate instead of ipnetwork.
  • This copies a fair amount of code that is also in-use by network-address, but allows the features to remain functional simultaneously.

@smklein smklein changed the title WIP implementation of ipnet based conversions ipnet-address feature, providing conversions to/from the ipnet crate May 4, 2022
@smklein smklein marked this pull request as ready for review May 4, 2022 13:24
@weiznich weiznich requested a review from a team May 5, 2022 07:19
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me if a changelog entry is added.
To note this somewhere: This likely won't be part of the initial 2.0 release, as it's not part of the RC release.

@weiznich
Copy link
Member

weiznich commented Jun 2, 2022

@smklein Just a remainder that this is only waiting for the Changelog entry to be added.

@smklein
Copy link
Contributor Author

smklein commented Jun 2, 2022

@smklein Just a remainder that this is only waiting for the Changelog entry to be added.

This is done; added it under "Unreleased", as you mentioned this would not be part of the 2.0 release.

@weiznich
Copy link
Member

weiznich commented Jun 3, 2022

The clippy CI failure seems to be relevant.

@smklein
Copy link
Contributor Author

smklein commented Jun 3, 2022

The clippy CI failure seems to be relevant.

Okay, I believe this has been fixed - mysql failures still look present, but those also look present on the master branch

@weiznich weiznich merged commit 05ced4b into diesel-rs:master Jun 3, 2022
@weiznich
Copy link
Member

weiznich commented Jun 3, 2022

mysql failures still look present, but those also look present on the master branch

Those are caused by an incompatibility between the visual studio version available on github actions and the installed libmysqlclient version. I'm not sure yet how to fix that.

@smklein smklein deleted the ipnet branch June 3, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants