Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support macaddr::MacAddr6 with Pg #3640

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fenollp
Copy link

@fenollp fenollp commented May 23, 2023

No description provided.

@weiznich
Copy link
Member

Thanks for opening this PR. I want to clarify a few point here before you put more work into the implementation.
As this adds another dependency to diesel I want to be sure that this dependency is:

  • Maintained
  • Trusted by the community
  • Commonly used

Additionally I would like to see arguments for whether that impl needs to be in diesel and not in this dependency crate (or another third party crate).

@fenollp fenollp force-pushed the macaddr6 branch 2 times, most recently from 5211147 to bcad500 Compare May 25, 2023 14:29
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants