Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #3933

Closed
wants to merge 1 commit into from
Closed

Add dependabot #3933

wants to merge 1 commit into from

Conversation

oriontvv
Copy link

This PR adds dependabot config

@weiznich
Copy link
Member

Thanks for opening this PR. Can you explain whether or not that will preserve currently specified minimal versions and how that will support version ranges (like those for the libsqlite3-sys crate)? Changing these minimal versions is not possible without issuing a major release.

@Eveeifyeve
Copy link

Even tho I am not the author but based on my uses and what the commit does it's doesn't but you can specify versions as I think. But really all it does it opens pr with the version updated you could just close the prs that you don't want.

@weiznich
Copy link
Member

Given that we use version ranges in many places that would mean that we get a lot of PR's that need to be closed. I personally rather spend the time to do manual updates before any release instead of closing a never ending stream of PR.

cc @diesel-rs/reviewers for your opinions

@kw217
Copy link

kw217 commented Jul 11, 2024

I agree. I've used dependabot previously in a large organisation with many repositories. It was a helpful way of ensuring the work got done and nothing was forgotten, but I also had a dread of arriving in the morning to a pile of PRs. As long as Diesel has a process that ensures this work is done, I don't see the need for change.

@weiznich
Copy link
Member

There seems to be a conses to not setup this integration.

@weiznich weiznich closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants