Fix an off-by-one error in g_markup_parse_context_parse(). (#142794,

Tue Jun 1 21:56:31 2004 Matthias Clasen <maclas@gmx.de> * glib/gmarkup.c (advance_char): Fix an off-by-one error in g_markup_parse_context_parse(). (#142794, Morten Welinder)
dieterv · Jun 2, 2004 · d131dec · d131dec
1 parent 7d662e3
commit d131dec
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,8 @@
+Tue Jun  1 21:56:31 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* glib/gmarkup.c (advance_char): Fix an off-by-one error 
+	in g_markup_parse_context_parse().  (#142794, Morten Welinder)
+
 Sun May 16 23:20:33 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* glib/gcompletion.c (g_completion_add_items):

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+Tue Jun  1 21:56:31 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* glib/gmarkup.c (advance_char): Fix an off-by-one error 
+	in g_markup_parse_context_parse().  (#142794, Morten Welinder)
+
 Sun May 16 23:20:33 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* glib/gcompletion.c (g_completion_add_items):

diff --git a/ChangeLog.pre-2-12 b/ChangeLog.pre-2-12
@@ -1,3 +1,8 @@
+Tue Jun  1 21:56:31 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* glib/gmarkup.c (advance_char): Fix an off-by-one error 
+	in g_markup_parse_context_parse().  (#142794, Morten Welinder)
+
 Sun May 16 23:20:33 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* glib/gcompletion.c (g_completion_add_items):

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
@@ -1,3 +1,8 @@
+Tue Jun  1 21:56:31 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* glib/gmarkup.c (advance_char): Fix an off-by-one error 
+	in g_markup_parse_context_parse().  (#142794, Morten Welinder)
+
 Sun May 16 23:20:33 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* glib/gcompletion.c (g_completion_add_items):

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
@@ -1,3 +1,8 @@
+Tue Jun  1 21:56:31 2004  Matthias Clasen  <maclas@gmx.de>
+
+	* glib/gmarkup.c (advance_char): Fix an off-by-one error 
+	in g_markup_parse_context_parse().  (#142794, Morten Welinder)
+
 Sun May 16 23:20:33 2004  Matthias Clasen  <maclas@gmx.de>
 
 	* glib/gcompletion.c (g_completion_add_items):

diff --git a/glib/gmarkup.c b/glib/gmarkup.c
@@ -662,16 +662,21 @@ unescape_text (GMarkupParseContext *context,
 static gboolean
 advance_char (GMarkupParseContext *context)
 {
+  g_return_val_if_fail (context->iter != context->current_text_end, FALSE);
 
   context->iter = g_utf8_next_char (context->iter);
   context->char_number += 1;
+
+  if (context->iter == context->current_text_end)
+    return FALSE;
+
   if (*context->iter == '\n')
     {
       context->line_number += 1;
       context->char_number = 1;
     }
 
-  return context->iter != context->current_text_end;
+  return TRUE;
 }
 
 static gboolean