Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make InstantClick work on more sites without configuration #94

Closed
wants to merge 18 commits into from
Closed

Make InstantClick work on more sites without configuration #94

wants to merge 18 commits into from

Commits on Sep 24, 2014

  1. Preserve script node attributes. 

    Some sites such as Dropbox.com use attributes on script nodes to
define how they should be ran (or include non-js script nodes).

Previously, only the innerHTML and src attributes would be preserved,
often triggering errors or broken functionality.  This change
uses the cloneNode function to copy the node while preserving
all attributes.

cloneNode is not supported by FF before 13, so if legacy support is
desired an alternate solution will have to be found.
    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    3aff921 View commit details
    Browse the repository at this point in the history

  2. Automatically load head assets 

    Previously assets in the head of the preloaded page wouldn't
be loaded, as only the body was copied.  After this change,
any tag in the head of the previous page, not in this page,
is added to the head after the switch.
    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    725844d View commit details
    Browse the repository at this point in the history

  3. Remove head elements which are not in the new page

    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    34516af View commit details
    Browse the repository at this point in the history

  4. Bind events to the document, rather than each link

    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    e8b764d View commit details
    Browse the repository at this point in the history

  5. Copy attributes (e.g. classes) from the new head and html elements to… 

    … the old one
    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    8c1459c View commit details
    Browse the repository at this point in the history

  6. Spelling

    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    fc0a927 View commit details
    Browse the repository at this point in the history

  7. Use null rather than false to make it a bit more clear that newUrl is… 

    … not a boolean parameter
    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    0a6ba5d View commit details
    Browse the repository at this point in the history

  8. Allow event cancellation 

    If someone has called `e.preventDefault()`, or returned false from
an event handler in IE8, respect that cancellation.
    @zackbloom
    zackbloom committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    14cc2d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2014

  1. Remove and readd all head elements to ensure script tags get executed… 

    … again. Don't remove attributes to not break Typekit and the like.
    @zackbloom
    zackbloom committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    925fdc5 View commit details
    Browse the repository at this point in the history

  2. Remove and readd all head elements to ensure script tags get executed… 

    … again. Don't remove attributes to not break Typekit and the like.
    @zackbloom
    zackbloom committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    750de62 View commit details
    Browse the repository at this point in the history

  3. Restore remove and add vars

    @zackbloom
    zackbloom committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    5d68f85 View commit details
    Browse the repository at this point in the history

  4. Switch to our own cloneNode implementation to ensure script tags get … 

    …reexecuted

Conflicts:
	instantclick.js
    @zackbloom
    zackbloom committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    a008851 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'drop-in' of github.com:EagerApps/instantclick into drop-in 

    Conflicts:
	instantclick.js
    @zackbloom
    zackbloom committed Oct 1, 2014
    Configuration menu
    Copy the full SHA
    7d636c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2014

  1. Copy node contents

    @zackbloom
    zackbloom committed Oct 2, 2014
    Configuration menu
    Copy the full SHA
    024e96f View commit details
    Browse the repository at this point in the history

  2. Eval replaced scripts

    @zackbloom
    zackbloom committed Oct 2, 2014
    Configuration menu
    Copy the full SHA
    494c69f View commit details
    Browse the repository at this point in the history

  3. Wait until the page has been swapped to rerun

    @zackbloom
    zackbloom committed Oct 2, 2014
    Configuration menu
    Copy the full SHA
    1544fc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2014

  1. Override document.write when the page is done loading to fix bug with… 

    … rerunning scripts that call it
    @zackbloom
    zackbloom committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    ae043fd View commit details
    Browse the repository at this point in the history

  2. Don't call initPage on the initial load, as that would just load all … 

    …the scripts twice.
    @zackbloom
    zackbloom committed Oct 13, 2014
    Configuration menu
    Copy the full SHA
    42c314f View commit details
    Browse the repository at this point in the history