Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extractors): support alpha values for solid colors in Figma #55

Merged
merged 2 commits into from
Jan 9, 2020
Merged

fix(extractors): support alpha values for solid colors in Figma #55

merged 2 commits into from
Jan 9, 2020

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Jan 8, 2020 •
edited
Loading

Fixes #55

@roperzh
Copy link
Member Author

roperzh commented Jan 8, 2020

Note: proper support including blending modes is coming soon.

@codecov
Copy link

codecov bot commented Jan 8, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e93a9ed). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage          ?   92.26%           
=========================================
  Files             ?      108           
  Lines             ?     2494           
  Branches          ?       73           
=========================================
  Hits              ?     2301           
  Misses            ?      173           
  Partials          ?       20

dbuscaglia
dbuscaglia approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@dbuscaglia dbuscaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roperzh roperzh merged commit 2153276 into master Jan 9, 2020
@roperzh roperzh deleted the rob/figma-solid-alpha branch January 9, 2020 19:45
@roperzh roperzh mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbuscaglia dbuscaglia dbuscaglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roperzh @dbuscaglia