feat(extractors): add missing typograph properties in Figma extractor #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roperzh wow that was fast thank you! |
dbuscaglia
approved these changes
Feb 10, 2020
| @@ -467,11 +471,11 @@ describe('Figma', () => { | |||
| { | |||
| name: 'Foobar Typograph', | |||
| initializer: | |||
| 'new Typograph({fontSize: 9001, color: Color.rgba(100, 100, 100, 1), font: helloFonts.Foobar.BoldItalic})', | |||
| 'new Typograph({letterSpacing: 0.4824822, fontSize: 9001, lineHeight: 11, color: Color.rgba(100, 100, 100, 1), font: helloFonts.Foobar.BoldItalic})', | |||
There was a problem hiding this comment.
these seem like magic numbers and are repeated. do we always just inline these things?
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 92.59% 92.59% +<.01%
==========================================
Files 113 113
Lines 2661 2662 +1
Branches 77 77
==========================================
+ Hits 2464 2465 +1
Misses 176 176
Partials 21 21 |
|
Thanks for the review! Yes, you are right, that is a just test mock we are using. Relevant changes are in Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.