Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extractors): quote invalid properties before generating diez code #78

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Feb 13, 2020

Fixes #75

@roperzh roperzh requested review from dbuscaglia and removed request for dbuscaglia February 13, 2020 23:10
Copy link
Contributor

@dbuscaglia dbuscaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #78 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   92.57%   92.49%   -0.08%     
==========================================
  Files         113      114       +1     
  Lines        2666     2692      +26     
  Branches       77       81       +4     
==========================================
+ Hits         2468     2490      +22     
- Misses        177      181       +4     
  Partials       21       21              

@roperzh roperzh merged commit ef6bbf8 into diez:master Feb 14, 2020
@roperzh roperzh deleted the rob/sanitize-extractors branch February 14, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap token names with quotes
2 participants