This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Feature/es module rename and default #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to be consistent with the following loaders: https://webpack.js.org/loaders/file-loader/#esmodule https://webpack.js.org/loaders/raw-loader/#esmodule https://webpack.js.org/loaders/url-loader/#esmodule https://webpack.js.org/loaders/json5-loader/#esmodule https://webpack.js.org/plugins/mini-css-extract-plugin/#esmodule
difelice
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened to address issue #44
In summary, the goal of this PR is to use the option name
esModuleinstead ofexportAsESM. This PR will also enable this behavior by default. This will help this loader be consistent with the following webpack loaders:Just to be coherent with other loaders such as: