This repository has been archived by the owner on Jan 10, 2022. It is now read-only.
[TG-5859] Always use Objenesis to instantiate objects #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the Travis command to install openjdk6 is failing. This also happens on develop. |
antlechner
force-pushed
the
antonia/objenesis-everywhere
branch
2 times, most recently
from
c8d49d0
to
ce16df8
Compare
antlechner
changed the base branch from
develop
to
antonia/pom-java6-compatibility
|
Based on #60, which has to be merged first as Travis no longer supports openjdk6. |
antlechner
force-pushed
the
antonia/pom-java6-compatibility
branch
from
50ae2cd
to
5b822ae
Compare
antlechner
force-pushed
the
antonia/objenesis-everywhere
branch
2 times, most recently
from
6d2a9e7
to
7d2ba28
Compare
antlechner
changed the base branch from
antonia/pom-java6-compatibility
to
develop
thk123
reviewed
Dec 18, 2018
| @@ -0,0 +1,12 @@ | |||
| package com.diffblue.deeptestutils.regression; | |||
There was a problem hiding this comment.
💡 It would be super awesome if you were you to add tests for what happens when creating abstract classes and interfaces since that code is a complicated under tested mess
There was a problem hiding this comment.
I will do this in the follow-up PR for https://diffblue.atlassian.net/browse/TG-5895, as that will fix the exception wrapping for interfaces and abstract classes.
Calling real constructors is problematic as they might have side effects that are not considered by Diffblue Cover. For example, a field could be set by calling a method on a static field, and Diffblue Cover would not know that this field should be set to something non-null. See the following commit for an example.
This test would fail without the changes from the previous commit.
antlechner
force-pushed
the
antonia/objenesis-everywhere
branch
from
7d2ba28
to
0987f74
Compare
thk123
approved these changes
Dec 19, 2018
antlechner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used real constructors if a constructor with no arguments was defined in the class to instantiate. Such a constructor could have code with side effects that Diffblue Cover is not analysing, which could lead to failing tests, see the regression test in this PR (added to a new folder
regressionto distinguish it from the unit tests generated by Diffblue Cover).It makes sense to always use Objenesis to create objects so we don't have to worry about accidentally causing side effects anywhere when we use reflection.