-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BMC: include macros in trace #518
Conversation
This adds the values of macro symbols (parameter, localparam, etc.) to the BMC trace.
trans_tracet::statet::assignmentt assignment; | ||
assignment.rhs = symbol.value; | ||
assignment.lhs = symbol.symbol_expr(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think trans_tracet::statet::assignmentt
should only be constructible with two or three (the source location) arguments, unless use with containers absolutely requires the presence of a default constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do as separate PR.
exprt indexed_symbol_expr(ID_symbol, symbol.type); | ||
|
||
indexed_symbol_expr.set( | ||
ID_identifier, timeframe_identifier(t, symbol.name)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this not use symbol_exprt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change, as separate PR.
This adds the values of macro symbols (
parameter
,localparam
, etc.) to the BMC trace.