BMC: include macros in trace #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the values of macro symbols (parameter, localparam, etc.) to the BMC trace.
tautschnig
approved these changes
May 21, 2024
Comment on lines
+65
to
+67
| trans_tracet::statet::assignmentt assignment; | ||
| assignment.rhs = symbol.value; | ||
| assignment.lhs = symbol.symbol_expr(); |
There was a problem hiding this comment.
I think trans_tracet::statet::assignmentt should only be constructible with two or three (the source location) arguments, unless use with containers absolutely requires the presence of a default constructor.
There was a problem hiding this comment.
Will do as separate PR.
Comment on lines
+73
to
+76
| exprt indexed_symbol_expr(ID_symbol, symbol.type); | ||
|
|
||
| indexed_symbol_expr.set( | ||
| ID_identifier, timeframe_identifier(t, symbol.name)); |
There was a problem hiding this comment.
Why does this not use symbol_exprt?
There was a problem hiding this comment.
Will change, as separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the values of macro symbols (
parameter,localparam, etc.) to the BMC trace.