-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fvirga/new annotation unit tests #1541
Conversation
@@ -125,69 +125,69 @@ def test_update_sequence_id_in_cache_list(self): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing has actually changed in this file, I just re-ordered the tests so that test cases for the same methods are grouped together
mock_get_member.assert_not_called() # Member was not fetched | ||
|
||
# TODO: This isnt working, got it from here https://stackoverflow.com/questions/32463321/how-to-assert-method-call-order-with-python-mock | ||
# func_calls.assert_has_calls([call.m1(), call.m2(), call.m3(), call.m4(), call.m5(), call.m6()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to add an assert to ensure we call each of these functions in the correct order, but couldnt get this strategy to work. Will revisit later if we still depend on the ordering.
Added some new unit tests to Annotation_Update. Putting these on hold for now and instead working on the Annotation_Update refactor, so figure we can just merge the new tests in.
Ignore the huge diff for
default/tests/shared/test_annotation.py
, I just re-ordered the tests so that similar tests were grouped together