Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cosmetic "Dataset Explorer, after scrolling down a certain amount error" #1585

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

anthony-chaudhary
Copy link
Member

Fixes
#1571

  • This was a "Cosmetic" only item, since the '0' object was not a valid file there was nothing to unselect.
  • The root of it injecting the '0' can be solved as part of refactoring the file push and concat block which should be seperate functions.

Additional Context

  • Error: Cannot create property 'selected' on string '0'
  • In theory a file object should never be a string '0', however, it seems to be adding this in, so until that root item is solved adding this check to filter out the '0's (which aren't valid file objects)
  • In limited testing it only seems to happen once, so some process is adding it in a funny way
    For example:
    file list has a zero

Context of error:
Cannot create property 'selected' on string '0'
In theory a file object should never be a string '0', however, it seems to be adding this in, so until that root item is solved adding this check to filter out the '0's (which aren't valid file objects)

In limited testing it only seems to happen once, so some process is adding it in a funny way
Copy link

github-actions bot commented Feb 14, 2024

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b9c94eb. ± Comparison against base commit e2fb3ab.

♻️ This comment has been updated with latest results.

@anthony-chaudhary anthony-chaudhary merged commit a6d4130 into master Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant