Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Profile Picture Upload to Use DataTools() #40

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

PJEstrada
Copy link
Contributor

This for better support of the other third party cloud providers and overall improvement of code abstraction.

@PJEstrada PJEstrada self-assigned this Apr 21, 2021
@PJEstrada PJEstrada marked this pull request as draft April 21, 2021 18:02
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anthony-chaudhary anthony-chaudhary marked this pull request as ready for review April 21, 2021 18:29
@anthony-chaudhary anthony-chaudhary marked this pull request as draft April 21, 2021 18:30
@PJEstrada
Copy link
Contributor Author

Merging this to add it to new release. Just waiting for tests to pass

@PJEstrada PJEstrada linked an issue Apr 21, 2021 that may be closed by this pull request
@PJEstrada PJEstrada marked this pull request as ready for review April 21, 2021 18:30
@cypress
Copy link

cypress bot commented Apr 21, 2021



Test summary

54 0 0 0Flakiness 0


Run details

Project DiffgramFrontend
Status Passed
Commit 8a64803
Started Apr 21, 2021 6:07 PM
Ended Apr 21, 2021 6:34 PM
Duration 26:57 💡
OS Linux Debian - 10.9
Browser Chrome 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@PJEstrada PJEstrada merged commit 5587986 into master Apr 21, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

  1 files  ±0    1 suites  ±0   48s ⏱️ ±0s
84 tests ±0  84 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5587986. ± Comparison against base commit 5587986.

@PJEstrada PJEstrada deleted the profile-pictures-datatools branch June 2, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images core process_profile_image is not using Data_tools()
2 participants