p2 bootstrap download url broken on maven repo

[k-brooks]

With 3.17.6, specifically d63ddb6, the process used to download the p2 bootstrap binary was changed.
The move introduced/exposed a few bugs.

1. The FileMisc.download method does not verify the content or the response code, it will dump the body of the response to the provided file.
2. I don't believe the FileNotFoundException fallback handling will ever be reached, and that issue may extend beyond problem 1 - I suspect the new library handles 404's differently.
3. The subsequent unzip of the 404 content proceeds without issue (or any output I can find)

I created https://gist.github.com/k-brooks/eca39b22aba3c5dcc791cdf4000b0633 to highlight issues 1 and 3. You'll need to update the p2BootstrapUrl to a maven style repo in order to exercise 2.

[nedtwigg]

Thanks for the detailed error report! Happy to merge and release any PRs to fix. I am fine with modifying OkHttp's configuration or with using a different library altogether. Only requirement is that it support redirects (the requirement which triggered including OkHttp in the first place).

[k-brooks]

Thanks for the prompt reply @nedtwigg - we were able to work around the issue for now, but will need to fix it eventually. When I get some time, I'll put a PR together.

[nedtwigg]

Fixed in 3.20.0