Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url for the p2 bootstrap install is hardcoded. #25

Closed
scottresnik opened this issue Dec 2, 2016 · 10 comments
Closed

Url for the p2 bootstrap install is hardcoded. #25

scottresnik opened this issue Dec 2, 2016 · 10 comments

Comments

@scottresnik
Copy link
Contributor

I am cursed to work behind a proxy, and have proxied all the P2 repos I need with our company's internal sonatype nexus instance. However, the bootstrap process relies on a hard coded url. This prevents the bootstrap process from completing.

@scottresnik
Copy link
Contributor Author

I was able to get around this by specifying the Java system properties for setting a proxy, but ideally, I'd like to override this url to something internal.

@nedtwigg
Copy link
Member

nedtwigg commented Dec 2, 2016

You should now be able to do:

com.diffplug.gradle.GoomphCacheLocations.override_p2bootstrapUrl = 'http://intranet/goomph-p2-boostrap'
// make sure actual URL location is http://intranet/goomph-p2-boostrap/4.5.2/goomph-p2-bootstrap.zip

@scottresnik
Copy link
Contributor Author

Thanks for the quick turn around. I quickly tried this using our nexus repo, and got burned by nexus appending the version at the end of the zip. Is there value in having the cache look for goomp-p2-bootstrap-4.5.2.zip ?

@nedtwigg
Copy link
Member

nedtwigg commented Dec 2, 2016

Sounds good to me! If you write something that works for you, I'll merge it to master and bundle into the next release.

@scottresnik
Copy link
Contributor Author

Fixed with merge of #26 .

@scottresnik
Copy link
Contributor Author

scottresnik commented Dec 12, 2016

So I discovered an issue with this fix. In my production project, I configure goomph in a separate buildscript, e.g. eclipse.gradle. Then from my main build.gradle, I do apply from: eclipse.gradle. The way the Gradle class path works, it appears that each build script ends up with a copy of the com.diffplug.gradle.GoomphCacheLocations which prevents the url from being set. Do you have any thoughts on where this value could be set for retrieval at task execution time?

@nedtwigg
Copy link
Member

You can now override the properties like this:

ext.goomph_override_p2bootstrapUrl='http://intranet/goomph-p2-boostrap'

These will survive the classloader isolation issues of apply from:.

@scottresnik
Copy link
Contributor Author

Thanks for the quick turnaround.

scottresnik added a commit to scottresnik/goomph that referenced this issue Dec 13, 2016
nedtwigg added a commit to scottresnik/goomph that referenced this issue Dec 13, 2016
nedtwigg added a commit that referenced this issue Dec 13, 2016
#25: Update GoomphCacheLocations after project evaluation.
@nedtwigg
Copy link
Member

Published in 3.7.0.

@hacki11
Copy link
Contributor

hacki11 commented Jan 8, 2018

how can i override the url for pde-bootstrap? all i can see is a p2BootstrapUrl override
PdeInstallations seems to not support this

return new File(GoomphCacheLocations.pdeBootstrap(), release.toString() + FileMisc.macApp());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants