Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p2asmaven causes NPE #145

Merged
merged 9 commits into from
Apr 8, 2021
Merged

Fix p2asmaven causes NPE #145

merged 9 commits into from
Apr 8, 2021

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Apr 7, 2021

Failed attempt to fix #144.

@nedtwigg
Copy link
Member Author

nedtwigg commented Apr 8, 2021

This is a janky fix, but it does bring p2asmaven back to its previous behavior.

  • basically our old 4.7.2 bootstrap requires Java 8
  • but our new 4.13.0 bootstrap doesn't work with p2asmaven, and I cannot figure out why
  • so, for just the case of p2asmaven, we use the old 4.7.2 bootstrap, which involves bringing back parts of the old EquinoxLauncher

This is super-hacky, but it means nobody needs to be stuck on an old version anymore.

@nedtwigg nedtwigg merged commit 26ea4e3 into main Apr 8, 2021
@nedtwigg nedtwigg deleted the feat/fix-p2asmaven branch April 8, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2AsMaven causes NullPointerException when looking for ANT tools
1 participant