Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installed jre #16

Merged
merged 6 commits into from Nov 24, 2016
Merged

Add installed jre #16

merged 6 commits into from Nov 24, 2016

Conversation

scottresnik
Copy link
Contributor

I added functionality to specify additional JRE's to be included in the workspace.

@nedtwigg
Copy link
Member

For future reference, you can just run gradlew spotlessApply and all the formatting issues will be resolved, including line ending problems. As-is, I can't tell what these commits actually do because of line ending and formatting mixups. Do you mind running spotlessApply and squashing them all into one? If you don't know git-fu, I can do it for you.

@nedtwigg
Copy link
Member

Sorry, should have opened with "looks like a great feature!". I'm excited to merge it in :)

@scottresnik
Copy link
Contributor Author

Missed spotless on the last commit. Squashed the formatting commits. Left the meat. I can squash further, if desired.

travis-ci added 3 commits November 23, 2016 22:23
…contained it within ConventionJdt.

This required adding a method to OomphConvention for specifying that the block is closed, so that values which have been accumulated can be flushed into actions.
…, and give links to the more detailed stuff later.
@nedtwigg nedtwigg merged commit a5ad8f3 into diffplug:master Nov 24, 2016
@nedtwigg
Copy link
Member

Thanks a ton for the great contribution! A couple questions:

  • How can I credit you in the acknowledgements? Scott Resnik? Would you like me to link to your github, twitter, elsewhere?
  • Shall I release this as 3.5.0, or is there more coming down the pike that you'd like to be included?

@scottresnik scottresnik deleted the add-installed-jre branch November 24, 2016 13:12
@scottresnik
Copy link
Contributor Author

  • RE: acknowledgements: I guess my name + github is fine. Just glad I could make a contribution to a useful plugin.
  • RE: 3.5.0: Ship it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants