Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle "com.ibm.icu" in eclipseMavenCentral #170

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Handle "com.ibm.icu" in eclipseMavenCentral #170

merged 1 commit into from
Nov 5, 2021

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Nov 4, 2021 •
edited

Fixes #167

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md that includes:

  • a summary of the change
  • a link to the newly created PR

This makes it easier for the maintainers to quickly release your changes.

nedtwigg
nedtwigg requested changes Nov 4, 2021
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the API broke.

src/main/java/com/diffplug/gradle/eclipse/MavenCentralMapping.java Show resolved Hide resolved
@nedtwigg nedtwigg merged commit 9f5523b into diffplug:main Nov 5, 2021
@nedtwigg
Copy link
Member

nedtwigg commented Nov 5, 2021

Published in 3.33.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg nedtwigg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eclipseMavenCentral: Version of "com.ibm.icu"
2 participants
@jmini @nedtwigg