Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up spotless-lib to 2.20.0 #176

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

KengoTODA
Copy link
Contributor

@KengoTODA KengoTODA commented Dec 28, 2021

Hello 馃憢 thanks for sharing such a nice Gradle plugin!
It helps a lot to remove dependency on Eclipse in local.

I'm trying to introduce this plugin to a Gradle project depending on the spotless gradle plugin.
But when I run the build, it failed due to the following error:

Receiver class com.diffplug.gradle.spotless.GradleProvisioner$DedupingProvisioner does not define or inherit an implementation of the resolved method 'abstract java.util.Set provisionWithDependencies(java.util.Collection)' of interface com.diffplug.spotless.Provisioner.

I found that this plugin depends on old spotless-lib, and it brings a conflict into the classpath. So in this PR, I want to suggest upgrading the spotless-lib to 2.20.0.


Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md that includes:

  • a summary of the change
  • a link to the newly created PR

This makes it easier for the maintainers to quickly release your changes.

@KengoTODA KengoTODA changed the title Bump up spotless-lib to 2.21.0 Bump up spotless-lib to 2.20.0 Dec 28, 2021
@KengoTODA
Copy link
Contributor Author

note: I use spotless-lib:2.20.0 which is not latest but used from the gradle/6.0.0.
I'm motivated to use this version, to avoid build failure caused by new API in the gradle/6.0.1 diffplug/spotless#872.

@KengoTODA KengoTODA marked this pull request as ready for review December 28, 2021 05:40
@nedtwigg nedtwigg merged commit 31878c4 into diffplug:main Dec 29, 2021
@nedtwigg
Copy link
Member

Published in 3.34.1

@KengoTODA KengoTODA deleted the upgrade-spotless-lib branch December 29, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants