Add support for includeLaunchers in product file #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
requested changes
Feb 24, 2018
|
|
||
| static Properties extractProperties(String[] lines) { | ||
| Properties props = new Properties(); | ||
| for (String line : lines) { |
There was a problem hiding this comment.
Maybe Map<String, String> props = new LinkedHashMap<>() instead of Properties?
| @@ -89,8 +90,11 @@ void setup(File destinationDir, PdeBuildProperties props, List<SwtPlatform> plat | |||
|
|
|||
| // now create the sanitized product file | |||
| File productFile = productPluginDir.toPath().resolve(productFileWithinPlugin).toFile(); | |||
| productFileLines = ProductFileUtil.readLines(productFile); | |||
| ProductFileUtil.extractProperties(productFileLines).forEach((key, value) -> props.setProp(key.toString(), value.toString())); | |||
|
|
|||
There was a problem hiding this comment.
After making the Map<String, String> change, this could be .forEach(props::setProp)
|
good catch, i applied them accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line is copied from a example product file:
<product uid="com.foo.plugin.product" id="com.foo.plugin.product" application="org.eclipse.ui.ide.workbench" version="1.0.0" useFeatures="false" includeLaunchers="false">PdeBuildTaskwill now extract this property and adds it toPdeBuildProperties.A launcher is now excluded or included in the PDE export.
@nedtwigg would you mind doing a code review?