This fixes #65 EquinoxLaunch cannot handle EXIT_ASYNC_RESULT #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the termination of the application and query then the exit code over the properties. This is needed, if the IApplication#start() returns IApplicationContext.EXIT_ASYNC_RESULT.
|
Looks great! Just update CHANGES.md and I'll merge and release. |
|
Great |
|
Something else missing? |
|
Sorry for the delay! Released as 3.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the termination of the application and query then the exit code over the properties.
This is needed, if the IApplication#start() returns IApplicationContext.EXIT_ASYNC_RESULT.
Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
-SNAPSHOTsection of CHANGES.md that includes:This makes it easier for the maintainers to quickly release your changes.