Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of Gradle built with #161

Closed
JLLeitschuh opened this issue Oct 31, 2017 · 1 comment
Closed

Update version of Gradle built with #161

JLLeitschuh opened this issue Oct 31, 2017 · 1 comment
Labels
enhancement

Comments

@JLLeitschuh
Copy link
Member

You can update the version of gradle that is used to build this project but still run the tests with the tooling API to test version 2.6.
This has been deprecated but will still be supported in 4.3
https://docs.gradle.org/current/release-notes.html#deprecations

Is there a reason why this project is still built with 2.6? Can we upgrade? Will we see a benefit (checking forward compatibility would be a good use case)?
@JLLeitschuh JLLeitschuh changed the title Update version of Gradle supported?? Update version of Gradle built with?? Oct 31, 2017
@nedtwigg
Copy link
Member

It's built with 2.14.1, not 2.6. Probably the build will be faster with a newer version, but we'll have to rely on testing to make sure it still works with the older versions, rather than compile-time checks.

I'd like to maintain compat with 2.14+. I've got some projects stuck on 2.14 indefinitely because in 3.x + any change to buildSrc causes a full rebuild.

I'd be happy to merge an update to 4.3 that includes testing against 2.14, but I don't care about this enough to do it.

@nedtwigg nedtwigg changed the title Update version of Gradle built with?? Update version of Gradle built with Oct 31, 2017
runningcode pushed a commit to runningcode/spotless that referenced this issue Jan 5, 2018
Update gradle version to 4.4.1.
f8ff66a 
Also maintain testing compatibility with 2.14.1.

Fixes diffplug#161
@runningcode runningcode mentioned this issue Jan 5, 2018
Merged
runningcode pushed a commit to runningcode/spotless that referenced this issue Jan 6, 2018
Update gradle version to 4.4.1.
51ab5e1 
Also maintain testing compatibility with 2.14.1.

Fixes diffplug#161
runningcode pushed a commit to runningcode/spotless that referenced this issue Jan 8, 2018
Update gradle version to 4.4.1.
569650d 
Also maintain testing compatibility with 2.14.1.

Fixes diffplug#161
nedtwigg pushed a commit that referenced this issue Jan 8, 2018
@runningcode @nedtwigg
Update gradle version to 4.4.1. (#186)
c8b92ca 
Also maintain testing compatibility with 2.14.1.

Fixes #161
@jbduncan jbduncan mentioned this issue Jul 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JLLeitschuh @nedtwigg