Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Antlr4 grammars #326

Closed
matthiasbalke opened this issue Dec 28, 2018 · 4 comments
Closed

Add support for Antlr4 grammars #326

matthiasbalke opened this issue Dec 28, 2018 · 4 comments

Comments

@matthiasbalke
Copy link
Contributor

matthiasbalke commented Dec 28, 2018

I'm working on an integration of antlr/Antlr4Formatter by @teverett. The formatter is in an early stage, but already formats Antlr4 grammars.

I started with the Gradle Plugin integration, but once thats done, would be willing to add support to Maven too. I'll push my current status within today, so we can talk about things that need to be done.

matthiasbalke added a commit to matthiasbalke/spotless that referenced this issue Dec 28, 2018
moved formatter to lib
use formatter version available on maven central
@jbduncan
Copy link
Member

jbduncan commented Dec 28, 2018

Sounds neat to me!

I used ANTLR when I was working on my dissertation a couple of years ago, so having an ANTLR grammar formatter included by default in Spotless sounds interesting to me.

I look forward to whatever work towards this that you manage to make. 👍

@matthiasbalke
Copy link
Contributor Author

@jbduncan Check out PR #273. The integration is complete and works. But the formatter library itself is getting fixed in the meantime.

@jbduncan
Copy link
Member

Cheers @matthiasbalke! I'd be more than happy to review it when you're ready. :)

@nedtwigg
Copy link
Member

nedtwigg commented Jul 2, 2020

Released in plugin-maven 2.0.0 and plugin-gradle 4.5.0.

@nedtwigg nedtwigg closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants