Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsolete - Add support for linters #1097

Closed
wants to merge 31 commits into from
Closed

obsolete - Add support for linters #1097

wants to merge 31 commits into from

Commits on Jan 14, 2022

  1. Define a Lint.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d5b0421 View commit details
    Browse the repository at this point in the history

  2. Add a lint method to FormatterStep and let it wripple through.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    db676fc View commit details
    Browse the repository at this point in the history

  3. Make Lint roundtrippable through a String.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    5dc6271 View commit details
    Browse the repository at this point in the history

  4. Formatter.lint

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cc71751 View commit details
    Browse the repository at this point in the history

  5. Lint ripples through DirtyState and Formatter.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    aac3972 View commit details
    Browse the repository at this point in the history

  6. SpotlessTaskImpl now generates both a formatted result and a lint res… 

    …ult.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    a25eded View commit details
    Browse the repository at this point in the history

  7. SpotlessTaskImpl now generates a lint result for check and for `app… 

    …ly` (the line numbers in a lint will change depending on whether the `apply` already ran or not).
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    89339cd View commit details
    Browse the repository at this point in the history

  8. Gradle spotlessCheck will now throw an error if all of the files are … 

    …as formatted as they can be, except for lints.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cac4f70 View commit details
    Browse the repository at this point in the history

  9. Maven spotless:check will now throw an error if all of the files are … 

    …as formatted as they can be, except for lints.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d4ec76b View commit details
    Browse the repository at this point in the history

  10. Default FormatterFunc.lint now traps errors from the formatter itse… 

    …lf, and tries to parse a line number from the error message.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    7a1e72a View commit details
    Browse the repository at this point in the history

  11. Remove FormatExceptionPolicy.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    109c7fb View commit details
    Browse the repository at this point in the history

  12. Remove FormatExceptionPolicy from the maven plugin.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    0049661 View commit details
    Browse the repository at this point in the history

  13. Replace FormatExceptionPolicy with LintPolicy inside the Gradle p… 

    …lugin.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    dd5165f View commit details
    Browse the repository at this point in the history

  14. Lint.toFile might need to create parent directories.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    85fbe71 View commit details
    Browse the repository at this point in the history

  15. Lints are now quietly suppressed during apply, you have to do `chec… 

    …k` to see them.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e8e5df5 View commit details
    Browse the repository at this point in the history

  16. Fix spotbugs warnings.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    6ec06cc View commit details
    Browse the repository at this point in the history

  17. Fix the bug I made from fixing spotbugs :)

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    9557c66 View commit details
    Browse the repository at this point in the history

  18. Make sure that FormatterFunc.Closeable's helpers support linting.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    2844068 View commit details
    Browse the repository at this point in the history

  19. Fix FormatterFunc.Closeable earlier

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    9134d8c View commit details
    Browse the repository at this point in the history

  20. Refactor PipeStepPair so that it can detect lost tags within our new … 

    …lint paradigm. The old way made it impossible to detect lost tags if `apply` always succeeds.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    5a9799d View commit details
    Browse the repository at this point in the history

  21. Rename PipeStepPair to FenceStep.

    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    07b39cb View commit details
    Browse the repository at this point in the history

  22. Removed rootDir property Formatter and its builder because it was… 

    … only used to annnotate errors, which is now done by the lint phase.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    78ddcd6 View commit details
    Browse the repository at this point in the history

  23. DiffMessageFormatter.Builder::formatter needs a new Path rootDir … 

    …parameter.
    @nedtwigg
    nedtwigg committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f947c7b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Adapt StepHarness for the new "exceptions never get thrown" environment.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    a3eef1f View commit details
    Browse the repository at this point in the history

  2. When a step throws an exception, we now accurately consider the entir… 

    …e file as linted, rather than just the first line.
    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    3f72b7e View commit details
    Browse the repository at this point in the history

  3. Fix tests.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    1ed3149 View commit details
    Browse the repository at this point in the history

  4. Fix spotbugs.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6e38887 View commit details
    Browse the repository at this point in the history

  5. Fix wrong SuppressFBWarnings import.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    eb0feed View commit details
    Browse the repository at this point in the history

  6. Fix tests on windows.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    248ec28 View commit details
    Browse the repository at this point in the history

  7. Fix prettier error test.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    3aa780e View commit details
    Browse the repository at this point in the history

  8. Make our testing parallel.

    @nedtwigg
    nedtwigg committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    e110426 View commit details
    Browse the repository at this point in the history