Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to output multiple errors when using ktlint #1403

Closed
wants to merge 4 commits into from

Conversation

makotokato
Copy link

Fixes #287

diktat doesn't throw an exception immediately when ktlint find lint error even if using ktlint, so ktlint shouldn't throw it like diktat, too.

@nedtwigg
Copy link
Member

Ah, shoot. This is a good PR, but I don't think I will merge it. The problem is that the FormatterFunc are ideally pure functions (for thread safety) and this makes them all stateful. We might be able to get away with it, but it's risky.

There is another PR sitting in drafts which addresses this same problem

But it addresses this for all the formatters (along with a general cleanup). I'm pretty slammed for the next couple weeks, but I'll try to get all those linter PR's merged before January.

@nedtwigg nedtwigg closed this Nov 24, 2022
@nedtwigg
Copy link
Member

Btw @makotokato , if you have comments on the interface in #1097 I would love to hear what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fail after first codestyle violation
2 participants