Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect sourceDirectory & testSourceDirectory configs for Java formatters #1553

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

lutovich
Copy link
Contributor

@lutovich lutovich commented Feb 4, 2023

Change Java formatters in the Maven plugin to respect sourceDirectory and testSourceDirectory. These are standard <build> configuration options to support projects with non-standard directory layout.

Maven plugin will now use sourceDirectory and testSourceDirectory to determine default include file masks for Java files. It will not use these configurations if an explicit <includes> configuration is present.

This change should be backward-compatible because Maven's default sourceDirectory and testSourceDirectory match the previously hardcoded default includes.

Closes #1214.

@nedtwigg nedtwigg merged commit 1774837 into diffplug:main Feb 4, 2023
@nedtwigg
Copy link
Member

nedtwigg commented Feb 4, 2023

Awesome, thanks!

@lutovich lutovich deleted the use-standard-mvn-dir-configs branch February 5, 2023 14:17
@nedtwigg
Copy link
Member

nedtwigg commented Feb 5, 2023

Released in plugin-maven 2.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin doesn't respect sourceDirectory/testSourceDirectory configurations
2 participants