PalantirJavaFormat in plugin-maven should take style parameter #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's on the document, but we don't actually have such a parameter.
tisonkun
commented
May 6, 2023
| @@ -27,9 +27,13 @@ public class PalantirJavaFormat implements FormatterStepFactory { | |||
| @Parameter | |||
| private String version; | |||
|
|
|||
| @Parameter | |||
| private String style; | |||
There was a problem hiding this comment.
Invalid parameter will failed on PalantirJavaFormatFormatterFunc.<init> calls JavaFormatterOptions.Style.valueOf(style).
tisonkun
commented
May 6, 2023
plugin-maven/src/main/java/com/diffplug/spotless/maven/java/PalantirJavaFormat.java
Show resolved
Hide resolved
|
@nedtwigg can I have a release to use it downstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's on the document, but we don't actually have such a parameter.
@nedtwigg