Fixed maven plugin dependency on plexus-resources #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POMs for publishing to maven central are generated using `./gradlew generatePomFileForPluginMavenPublication` command. Generated POMs include compile dependencies from gradle build scripts with `<scope>compile</scope>`. Dependency `org.codehaus.plexus:plexus-resources:1.0.1` was declared as compile-only in the gradle build script. This made POM generation skip it. So published plugin did not specify all needed dependencies in it's POM, which resulted in `NoClassDefFoundError` errors. This commit fixes the problem by declaring `plexus-resources` dependency with compile scope. Generated POM then contains it as a correct scope-compile dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POMs for publishing to maven central are generated using
./gradlew generatePomFileForPluginMavenPublicationcommand. Generated POMs include compile dependencies from gradle build scripts with<scope>compile</scope>. Dependencyorg.codehaus.plexus:plexus-resources:1.0.1was declared as compile-only in the gradle build script. This made POM generation skip it. So published plugin did not specify all needed dependencies in it's POM, which resulted inNoClassDefFoundErrorerrors.This PR fixes the problem by declaring
plexus-resourcesdependency with compile scope. Generated POM then contains it as a correct scope-compile dependency.Fixes #212