Linting - API #2149
Draft
Linting - API #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbidden characters." This reverts commit 9afa6dd.
…on't call it in the "special" way.
nedtwigg
force-pushed
the
feat/lint-take-2
branch
from
6f92ad7
to
a94dce9
Compare
…for easy API conversion.
…oser to the old behavior.
…) gets stored into every slot of `ValuePerStep` per invocation.
…at` calls and `lint` calls.
blacelle
reviewed
Jun 4, 2024
blacelle
reviewed
Jun 4, 2024
| } | ||
|
|
||
| public static Lint create(String code, String msg, int lineStart, int lineEnd) { | ||
| if (lineEnd < lineStart) { |
There was a problem hiding this comment.
Given lineNumberFor, lineNumber=-1 could be given a specific semantic (e.g. somewhere_undefined).
There was a problem hiding this comment.
That's a good call, it's probably a mistake to pretend that every Lint knows the range that it applies to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotless is still primarily a formatter, not a linter. But when formatting fails, it's more flexible to model those failures as lints so that the formatting can continue. For example, issues like
spotlessCheckcould add comments and suggested fix to GitHub PR #655are difficult to resolve with our current model, because the only channel we have to communicate with the user is "this is the formatted content". Now we have two channels: "this is the formatted content" and "these are the problems we had".
At this point, the purpose of these lints is just to do formatting better. They are an implementation detail. If people start submitting PRs for more linters, perhaps it will turn into something more. Who knows!