Eclipse 4.8.0 (JDT) #262
Merged
Eclipse 4.8.0 (JDT) #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your call. |
nedtwigg
requested changes
Jul 19, 2018
| private static Class<?> getClass(State state) { | ||
| if (state.getMavenCoordinate(MAVEN_GROUP_ARTIFACT).isPresent()) | ||
| return state.loadClass(FORMATTER_CLASS); | ||
| return state.loadClass(FORMATTER_CLASS_OLD); |
There was a problem hiding this comment.
Ifs without brackets are dangerous. I would change to this:
if ( ) {
return
} else {
return
}
nedtwigg
approved these changes
Jul 19, 2018
nedtwigg
requested changes
Jul 19, 2018
| @@ -42,8 +42,7 @@ | |||
| public final class JarState implements Serializable { | |||
| private static final long serialVersionUID = 1L; | |||
|
|
|||
| @SuppressWarnings("unused") | |||
| private final Set<String> mavenCoordinates; | |||
| private final TreeSet<String> mavenCoordinates; | |||
There was a problem hiding this comment.
Sorry, I almost missed this one. There are corner-cases where classpath order matters. Unless we have a really compelling reason, I think we should keep this as Set and not TreeSet
There was a problem hiding this comment.
Just wanted to emphasize that I expect a deterministic result for getMavenCoordinates for the same input. I do not insist. What's your final decision?
There was a problem hiding this comment.
then feel free to press the merge button, and I'll test the master integration build on some of my projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made Spotless-Eclipse-JDT 4.8.0 default version.
Added functionality to lookup Maven Coordinate information from Jar-State as @nedtwigg proposed in #234.
This PR fixes issues #226 and #191.