Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padded cell #455

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Fix padded cell #455

merged 5 commits into from
Sep 23, 2019

Commits on Sep 23, 2019

  1. Bump for latest ide version.

    @nedtwigg
    nedtwigg committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    47ec934 View commit details
    Browse the repository at this point in the history

  2. Add a test to PaddedCellTaskTest which checks a well-behaved formatte… 

    …r, which shows the problem:

- if a file is formatted badly
- but the step itself is well-behaving on this file (is idempotent)
- then Spotless will not mark the failure

Effectively, paddedCell() was accidentally giving a pass to badly-formatted files, but only if their formatter was well-behaved on that particular file.
    @nedtwigg
    nedtwigg committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    ef972b2 View commit details
    Browse the repository at this point in the history

  3. Fixed the bug in PaddedCellBulk.

    @nedtwigg
    nedtwigg committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    0427f11 View commit details
    Browse the repository at this point in the history

  4. Update changelog.

    @nedtwigg
    nedtwigg committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    60eadd9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feature/fix-padded-cell

    @nedtwigg
    nedtwigg committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    e429f9f View commit details
    Browse the repository at this point in the history