Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle 6+ #503

Merged
merged 18 commits into from
Jan 1, 2020
Merged

Fix Gradle 6+ #503

merged 18 commits into from
Jan 1, 2020

Commits on Jan 1, 2020

  1. Bump gradle to 6.0.1

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    d32216c View commit details
    Browse the repository at this point in the history

  2. Remove the build-scan plugin because it doesn't work on 6.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    51a8d31 View commit details
    Browse the repository at this point in the history

  3. Fix compile-deprecation in plugin-maven.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    957c0f4 View commit details
    Browse the repository at this point in the history

  4. Add spotless.resolveDependenciesIn as a workaround Gradle 6 constra… 

    …ints
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    d9397a1 View commit details
    Browse the repository at this point in the history

  5. Revert "Add spotless.resolveDependenciesIn as a workaround Gradle 6… 

    … constraints"

This reverts commit d9397a1.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    3b412df View commit details
    Browse the repository at this point in the history

  6. Improve the error message in JavaExtension if there's no target.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    ef65960 View commit details
    Browse the repository at this point in the history

  7. Make it possible for code within a lazy configuration to figure out w… 

    …hich step is being configured.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    28d8962 View commit details
    Browse the repository at this point in the history

  8. Create a :spotlessRegisterDependencies task, and use it to resolve th… 

    …e Gradle 6+ deprecation warnings.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    5 Configuration menu
    Copy the full SHA
    892203d View commit details
    Browse the repository at this point in the history

  9. Fix the maven build.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    ad86915 View commit details
    Browse the repository at this point in the history

  10. Fix build scan bug in our CI.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    e1980bd View commit details
    Browse the repository at this point in the history

  11. Improve javadoc.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    9f15a66 View commit details
    Browse the repository at this point in the history

  12. Figured out a way to do it 100% transparently, without requiring decl… 

    …arations in root. We can infer them without a performance penalty by registering every subproject SpotlessTask with the RegisterDependenciesTask. When we eventually bump our minimum-required gradle to take advantage of task configuration avoidance, this workaround will still work - the only task we'll have to create eagerly is the registerDependencies task.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    342386c View commit details
    Browse the repository at this point in the history

  13. Reorganized - all provisioner stuff into GradleProvisioner, all the r… 

    …est into RegisterDependenciesTask.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    c08b4c7 View commit details
    Browse the repository at this point in the history

  14. Revert "Make it possible for code within a lazy configuration to figu… 

    …re out which step is being configured."

This reverts commit 28d8962.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    addcf1e View commit details
    Browse the repository at this point in the history

  15. Update changelog.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    d41ac59 View commit details
    Browse the repository at this point in the history

  16. Remove the #372 workaround, since we don't need it anymore.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    67fc9d8 View commit details
    Browse the repository at this point in the history

  17. Minor improvement to the JitPack info.

    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    062e9e6 View commit details
    Browse the repository at this point in the history

  18. RegisterDependenciesTask now asserts that it is applied to only the r… 

    …oot project.
    @nedtwigg
    nedtwigg committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    7535906 View commit details
    Browse the repository at this point in the history