Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support google-java-format 1.8+ #563

Merged
merged 13 commits into from
May 3, 2020
Merged

Support google-java-format 1.8+ #563

merged 13 commits into from
May 3, 2020

Commits on May 2, 2020

  1. Support google-java-format 1.8+. 

    In google-java-format 1.8, the signature of
RemoveUnusedImports#removeUnusedImports changed and the
RemoveUnusedImports$JavadocOnlyImports class was removed entirely.
With this patch, GoogleJavaFormatStep detects which version of the
method is available and calls the right one.

Fixes diffplug#562.
    @benkard
    benkard committed May 2, 2020
    Configuration menu
    Copy the full SHA
    dbc4762 View commit details
    Browse the repository at this point in the history

  2. Add change log entries for PR diffplug#563.

    @benkard
    benkard committed May 2, 2020
    Configuration menu
    Copy the full SHA
    6f7aa17 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2020

  1. Add ability to detect what version of JRE we're running on, and use i… 

    …t to get the build to work on both JRE 8 and 11.
    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    2d4eeda View commit details
    Browse the repository at this point in the history

  2. Fix extra tests in Travis.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    8bfc8b3 View commit details
    Browse the repository at this point in the history

  3. Modifications to get ErrorShouldRethrow to pass on Gradle 5 (oldest… 

    … gradle version that supports Java 11).
    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    6d47868 View commit details
    Browse the repository at this point in the history

  4. Fixup - all tests should now pass on Java 8 and 11.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    9ce3dff View commit details
    Browse the repository at this point in the history

  5. Disable spotbugs on Java 11.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    717b479 View commit details
    Browse the repository at this point in the history

  6. Add test for google-java-format 1.8+, which is skipped on JRE 8.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    c0a8469 View commit details
    Browse the repository at this point in the history

  7. Disable javadoc on 11.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    5af53aa View commit details
    Browse the repository at this point in the history

  8. Disable the maven build for Java 11.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    88ca46e View commit details
    Browse the repository at this point in the history

  9. Fix the small behavior change in the latest google-java-format.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    11f58d8 View commit details
    Browse the repository at this point in the history

  10. Add Java 11 info to the changelogs.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    7ebb481 View commit details
    Browse the repository at this point in the history

  11. Use the same mechanism to disable tasks on Java 11 throughout the build.

    @nedtwigg
    nedtwigg committed May 3, 2020
    Configuration menu
    Copy the full SHA
    0104f6d View commit details
    Browse the repository at this point in the history