Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -PspotlessFiles from gradle (still available in maven) #602

Merged
merged 2 commits into from Jun 5, 2020

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Jun 5, 2020

-PspotlessFiles has been deprecated and will be removed. It is slow and error-prone, especially for win/unix cross-platform, and we have better options available now:

@nedtwigg nedtwigg merged commit e374870 into master Jun 5, 2020
@nedtwigg nedtwigg deleted the feat/deprecate-spotlessFiles branch June 5, 2020 04:37
@nedtwigg nedtwigg changed the title Deprecate -PspotlessFiles. Deprecate -PspotlessFiles from gradle (still available in maven) Jun 5, 2020
@driv
Copy link
Contributor

driv commented Nov 13, 2020

SpecificFIlesTest fails in Windows, during gradle check. It uses -DspotlessFiles.

From what I understand it's not worth looking into fixing it?

@nedtwigg
Copy link
Member Author

It is removed from gradle, but still used in maven. Probably

String rel = "src/main/java/test" + number + ".java";
if (absolute) {
return rootFolder() + "/" + rel;
} else {
return rel;
}
needs to be adjusted by
/** Transforms a unix path to a native one. */
public static String pathUnixToNative(String pathUnix) {
return pathUnix.replace('/', File.separatorChar);
}

We have a pretty big test matrix, but I guess we're not testing the maven plugin on windows...

It's not critical to fix, but if you're already in the weeds it would be nice to fix.

@driv
Copy link
Contributor

driv commented Nov 14, 2020

There's some issue with patterns from what I can get. Replacing / with \ generates an invalid regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants