Rename eclipse to eclipseCdt
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`, to avoid confusion with the other `eclipse()` used for java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
javablocks of gradle and maven,eclipse()meanseclipse jdt, while in thecppblocks, it meanseclipse cdt. It's a bit inconsistent, because in thegroovyblock,greclipse()is distinct (as it has to be, to disambiguate fromjdtversion).After the readme refactor, the docs work better if every step has a unique name, so this PR changes the name of the
Eclipse CDTbased formatter step toeclipseCdtin both gradle and maven. The docs were already updated to this in the above-linked readme refactor.