Performance functional-bug fix for the Maven-plugin #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for directory scanning with include/exclude pattern(s)
|
Have you used https://github.com/diffplug/spotless/blob/main/CONTRIBUTING.md#maven to integration test this? I might be wrong, but I would expect https://github.com/diffplug/spotless/blob/main/plugin-maven/src/test/resources/pom-build.xml.mustache to need changes as well. |
|
Published in |
|
Yeah, I followed the instructions and tested it manually. From looking at the generated pom, it doesn't seem that pom-build.xml.mustache needs to be updated (it makes a direct dependency to plexus-utils:3.3.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded org.codehaus.plexus:plexus-utils to its latest version (3.3.0) to resolve long directory scanning times for the maven plugin.
Resolves #729