updated to use gateway framework 2.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenad
requested review from
paddywalsh and
halljon
and removed request for
paddywalsh
halljon
approved these changes
Dec 1, 2023
| @@ -0,0 +1,16 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
There was a problem hiding this comment.
I think its fine. Makes it easier to run in IDE.
| * | ||
| * @author DiffusionData Ltd | ||
| */ | ||
| public final class SimpleJSONToCsvStringConvertor | ||
| implements OutboundPayloadConvertor<String, JSON> { | ||
| public final class SimpleJSONToCsvStringConverter |
There was a problem hiding this comment.
"JSON" or "Json"? The class name uses "Csv" for "CSV". I prefer Json mixed-case ;-)
There was a problem hiding this comment.
All caps types JSON/INT64 etcs is used across framework and else where to specify Diffusion topic types.
| @@ -0,0 +1,16 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| @@ -96,7 +97,7 @@ public SourceServiceProperties getSourceServiceProperties() throws InvalidConfig | |||
| return | |||
| newSourceServicePropertiesBuilder() | |||
| .updateMode(UpdateMode.STREAMING) | |||
| .payloadConvertorName("$CSV_to_JSON") | |||
| .payloadConverter("$CSV_to_JSON") | |||
There was a problem hiding this comment.
This one seems to still have the dollar prefix, but the JSON_TO_CSV doesn't.
There was a problem hiding this comment.
all framework provided converters have dollar prefixes and customs one created in application do not.
halljon
approved these changes
Dec 1, 2023
naveenad
force-pushed
the
upgrade-framework
branch
from
dad98fe
to
871e609
Compare
naveenad
force-pushed
the
upgrade-framework
branch
from
871e609
to
5aab011
Compare
naveenad
force-pushed
the
upgrade-framework
branch
from
5aab011
to
e312289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.