Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some initial doc comments to mm0-rs #32

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Conversation

ammkrn
Copy link
Contributor

@ammkrn ammkrn commented Jul 28, 2020

I've just been writing these as personal notes, but potential contributors might find them of interest. They're nowhere near complete obviously, but it's a start.

mm0-rs/src/lined_string.rs Show resolved Hide resolved
mm0-rs/src/lined_string.rs Show resolved Hide resolved
mm0-rs/src/lined_string.rs Outdated Show resolved Hide resolved
mm0-rs/src/parser.rs Outdated Show resolved Hide resolved
mm0-rs/src/parser.rs Outdated Show resolved Hide resolved
mm0-rs/src/parser/ast.rs Outdated Show resolved Hide resolved
mm0-rs/src/parser/ast.rs Outdated Show resolved Hide resolved
/// The data portion of an S-Expression.
///
/// Notable additions over a normal Lisp are Formula, which are just in-line formulas,
/// and DottedList, which provides some (slightly confusing at first but actually really nice)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DottedList is from lisp though? I didn't invent (a b . c) syntax.

mm0-rs/src/util.rs Outdated Show resolved Hide resolved
mm0-rs/src/util.rs Outdated Show resolved Hide resolved
@digama0 digama0 merged commit 74c6262 into digama0:master Jul 28, 2020
@ammkrn ammkrn deleted the doc_branch branch July 28, 2020 20:37
@ammkrn
Copy link
Contributor Author

ammkrn commented Jul 28, 2020

Thanks for the corrections, especially wrt DottedList.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants