Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix chainguard image base #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janderssonse
Copy link
Contributor

@janderssonse janderssonse commented Dec 6, 2023

A minimalist approach to fix the changes from chainguard regarding usage of the their jdk images.
Tested quickly locally, and seemed to build and run fine.

(Note: @fredriknordlander @jonassodergren It really itched in my fingers to add java 17, clean up the workflow, add a jar build, bump and test dependecies and so on. But kept it as small I could due to time restrictions. However I might add some further small and seperated PR's to this project. Maybe a jdk 17 base could be a good start, as that allows for bumps of spring etc). Do you want to leave all that fun to other devs, or ,otherwise a few quality related PR's might be coming when I get the time).

Fixes #26

Checklist

  • Changes are limited to a single goal (avoid scope creep)
  • I confirm that I have read any Contribution and Development guidelines (CONTRIBUTING and DEVELOPMENT) and are following their suggestions.
  • I confirm that I wrote and/or have the right to submit the contents of my Pull Request, by agreeing to the Developer Certificate of Origin, (adding a 'sign-off' to my commits).

Signed-off-by: Josef Andersson <josef.andersson@digg.se>
@ayeshabhatti78
Copy link
Contributor

@janderssonse The pull request has conflicts. Please fix the conflicts so that I can merge it to main.

@janderssonse
Copy link
Contributor Author

@janderssonse The pull request has conflicts. Please fix the conflicts so that I can merge it to main.

I noticed a lot of things were bumped, good work!. I'll get to fixing conflicts it the coming days at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACTION REQUIRED: Changes to pulling Chainguard Images
2 participants